Add explicit multiport virtio-console API #422
Draft
+923
−258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make PortDescription a struct instead of an enum with variants. This will allow for more flexibility when describing behavior of console ports. Signed-off-by: Matej Hrica <[email protected]>
When using krun_add_virtio_console_default with file descriptors that weren't normal STDIN/STDOUT/STDERR we could get weird behavior that wasn't in line with the behavior specified in the header. This also makes sure to set the change the terminal mode actually associated with the provided file descriptors instead of changing the terminal mode associated with normal stdin/stdout/stderr. Signed-off-by: Matej Hrica <[email protected]> fixups Signed-off-by: Matej Hrica <[email protected]>
Previosly we were assuming stdin is terminal using it to determine the terminal size. Attach a PortTerminalProperties trait object to each port for querying the correct terminal size. Note that this still only supports dynamically resizing the first port (upon SIGWINCH). Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
…nsole Remove the assertion that the first port must have terminal properties. This is not actually enforced by the spec, the only problem is you can't use such virtio console for as the kernel argument. Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
force-pushed
the
multiport-console-api
branch
2 times, most recently
from
89d99c4 to
c10f1d1
Compare
Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
force-pushed
the
multiport-console-api
branch
from
c10f1d1 to
601f67c
Compare
Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.